Add scheduler plans to runtime strategy switches#54
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d4d9af944
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "account_scope": account_scope, | ||
| "service_name": service_name, | ||
| "execution_mode": execution_mode, | ||
| "scheduler": _scheduler_plan_for_strategy(strategy_profile), |
There was a problem hiding this comment.
This now always emits runtime_target.scheduler, but the published contract in schemas/runtime-target.schema.json still sets runtime_target.additionalProperties to false and does not list scheduler among the allowed properties (schema lines 37-50). Any generated switch target or saved target that includes this field will be rejected by consumers/editors using the repository schema even though runtime_settings.py validate accepts it, so the schema needs to be extended alongside this output change.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d4d9af944
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "account_scope": account_scope, | ||
| "service_name": service_name, | ||
| "execution_mode": execution_mode, | ||
| "scheduler": _scheduler_plan_for_strategy(strategy_profile), |
There was a problem hiding this comment.
This now always emits runtime_target.scheduler, but the published contract in schemas/runtime-target.schema.json still sets runtime_target.additionalProperties to false and does not list scheduler among the allowed properties (schema lines 37-50). Any generated switch target or saved target that includes this field will be rejected by consumers/editors using the repository schema even though runtime_settings.py validate accepts it, so the schema needs to be extended alongside this output change.
Useful? React with 👍 / 👎.
1 participant
Summary
Tests